fix(log_bridge): start with the default config#449
Conversation
exclude_nodes/include_only_nodes: [] in the default YAML are untyped and abort the node at startup (InvalidParameterValueException: No parameter value set). Comment them out with examples so the node's typed defaults apply. Closes #444
There was a problem hiding this comment.
Pull request overview
Fixes ros2_medkit_log_bridge startup failure when using the shipped default params file by avoiding untyped empty YAML lists for exclude_nodes / include_only_nodes, allowing the node’s typed declared defaults to apply.
Changes:
- Remove
exclude_nodes: []andinclude_only_nodes: []fromconfig/log_bridge.yaml. - Add commented guidance/examples for enabling those filters with non-empty lists.
bburda
left a comment
bburda
left a comment
There was a problem hiding this comment.
Verified the fix. The two list params are the only empty-list entries in the YAML, the node declares both with typed empty-vector defaults, so commenting them out keeps the same behavior and stops the startup abort. No other empty lists remain.
bburda
dismissed
their stale review
Dismissing to complete a deeper review before sign-off.
bburda
left a comment
bburda
left a comment
There was a problem hiding this comment.
Verified the fix across the config, the node parameter declarations, the launch path and other params files in the repo. The two commented-out list params are the only empty-list entries, the node declares both with typed empty-vector defaults so behavior is unchanged, no launch file or other params file re-introduces the empty list, and the installed config is the edited one. Startup abort is resolved.
The shipped
config/log_bridge.yamlsetsexclude_nodes: []andinclude_only_nodes: []. Empty YAML lists are untyped, so launching the node with this file aborts at startup:The node code is correct (
declare_parameter<std::vector<std::string>>(..., {})); only the shipped YAML breaks it. This comments out the two lines with non-empty examples, so the node's typed defaults apply.Before:
ros2 run ros2_medkit_log_bridge log_bridge_node --ros-args --params-file config/log_bridge.yaml-> Aborted.After:
LogBridge started (topic=/rosout, severity_floor=30, prefix=LOG).Closes #444